Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24667 )
Change subject: WIP: IMPALA-15237: Test Calcite logical Substrait export ...................................................................... Patch Set 1: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24667/1/java/calcite-planner/src/test/java/org/apache/impala/calcite/service/CalciteSubstraitCompatibilityTest.java File java/calcite-planner/src/test/java/org/apache/impala/calcite/service/CalciteSubstraitCompatibilityTest.java: http://gerrit.cloudera.org:8080/#/c/24667/1/java/calcite-planner/src/test/java/org/apache/impala/calcite/service/CalciteSubstraitCompatibilityTest.java@157 PS1, Line 157: PreImpalaConvertResult supported = createPreImpalaConvertPlan("select 1 as value_col"); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24667/1/java/calcite-planner/src/test/java/org/apache/impala/calcite/service/CalciteSubstraitCompatibilityTest.java@283 PS1, Line 283: io.substrait.plan.Plan.ExecutionBehavior.VariableEvaluationMode.PER_PLAN) line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24667/1/java/calcite-planner/src/test/java/org/apache/impala/calcite/service/CalciteSubstraitCompatibilityTest.java@331 PS1, Line 331: Enumeration<URL> resources = loadedClass.getClassLoader().getResources(resourceName); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I359d6d6f88df63a7b0fdf7c6d541ec884602852f Gerrit-Change-Number: 24667 Gerrit-PatchSet: 1 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 06 Aug 2026 04:39:22 +0000 Gerrit-HasComments: Yes
