Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24605 )

Change subject: IMPALA-15195: Calcite Planner performance improvements for tpcds
......................................................................


Patch Set 7:

(3 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24605/7/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TestCalciteStats.java
File 
java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TestCalciteStats.java:

http://gerrit.cloudera.org:8080/#/c/24605/7/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TestCalciteStats.java@36
PS7, Line 36: import org.apache.calcite.rel.core.Project;
unused import: org.apache.calcite.rel.core.Project


http://gerrit.cloudera.org:8080/#/c/24605/7/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TestCalciteStats.java@64
PS7, Line 64: import static org.junit.Assert.assertTrue;
unused import: org.junit.Assert.assertTrue


http://gerrit.cloudera.org:8080/#/c/24605/7/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TestCalciteStats.java@306
PS7, Line 306:   private RelNode runFilterRule(CalciteAnalysisResult 
analysisResult) throws ImpalaException {
line too long (94 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/24605
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ee6662dc6500ea6ebd9f859de4df1740c51a058
Gerrit-Change-Number: 24605
Gerrit-PatchSet: 7
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Comment-Date: Thu, 06 Aug 2026 04:36:27 +0000
Gerrit-HasComments: Yes

Reply via email to