Gowthami Bisati has uploaded this change for review. (
http://gerrit.cloudera.org:8080/24670
Change subject: IMPALA-14489: Add missing OpenTelemetry custom cluster test
cases
......................................................................
IMPALA-14489: Add missing OpenTelemetry custom cluster test cases
Adds missing test cases to test_otel_trace.py to expand test coverage
for OpenTelemetry tracing under admission control cancellations and
multi-statement query sessions.
Summary of test cases added to TestOtelTraceSelectsDMLs:
1. test_admission_control_rejection
Validates that when a query fails or gets canceled while inside
Admission Control, Impala's OpenTelemetry engine correctly outputs
spans up through AdmissionControl, flags the error on the
AdmissionControl span, and omits downstream QueryExecution spans.
- Uses SCHEDULER_SCHEDULE:SLEEP@5000 to pause a query inside
admission control, then issues KILL QUERY.
- Confirms OpenTelemetry emits error traces up to AdmissionControl,
records the cancellation event, and omits the QueryExecution span.
2. test_combined_multistatement_query
Verifies that when multiple SQL statements (e.g., INVALIDATE METADATA
followed by SELECT) are executed sequentially within the same
connection session, OpenTelemetry tracing generates accurate and
independent trace trees for each statement.
Testing performed:
- Ran checkstyle to verify code formatting compliance.
- Ran mvn clean package -DskipTests (BUILD SUCCESS).
- Ran impala-py.test -v -s tests/custom_cluster/test_otel_trace.py
(All tests PASSED).
- Ran python3 bin/jenkins/critique-gerrit-review.py --dryrun
- Ran bin/impala-py.test --exploration_strategy=exhaustive \
tests/custom_cluster/test_workload_mgmt_init.py (All tests PASSED)
Change-Id: Ibf20c110d64ac64c19347f8c6682366256dbb2b2
Signed-off-by: Gowthami Bisati <[email protected]>
---
M tests/custom_cluster/test_otel_trace.py
1 file changed, 60 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/24670/1
--
To view, visit http://gerrit.cloudera.org:8080/24670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf20c110d64ac64c19347f8c6682366256dbb2b2
Gerrit-Change-Number: 24670
Gerrit-PatchSet: 1
Gerrit-Owner: Gowthami Bisati <[email protected]>