Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24556 )
Change subject: IMPALA-15127: Support HBO for UnionNode cardinality ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/24556/8/fe/src/main/java/org/apache/impala/planner/UnionNode.java File fe/src/main/java/org/apache/impala/planner/UnionNode.java: http://gerrit.cloudera.org:8080/#/c/24556/8/fe/src/main/java/org/apache/impala/planner/UnionNode.java@415 PS8, Line 415: populateHboThriftFields(msg, serialCtx); > `populateHboThriftFields()` also runs for a constants-only Union. Its key i PS12 still leaves a no-scan path through a parent node. `select 1 union select 2` creates an AggregationNode above the constants-only UnionNode. The Union skips HBO serialization, but the aggregation still gets an HBO key while `appendScanInputStats()` leaves `scan_input_stats` unset. A later update for the same key reaches `HistoricalStats.getSimilarRunIndex()` and fails its non-empty precondition. Could we handle the empty scan list in the shared `populateHboThriftFields()` path, or otherwise suppress HBO fields for the parent, and add a regression test for this DISTINCT plan shape? -- To view, visit http://gerrit.cloudera.org:8080/24556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie228f530bdcb171d3b717966673164bf9a4c45c8 Gerrit-Change-Number: 24556 Gerrit-PatchSet: 8 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 13 Aug 2026 07:36:15 +0000 Gerrit-HasComments: Yes
