Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22091 )

Change subject: IMPALA-13531: Calcite CTE frontend
......................................................................


Patch Set 41:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22091/41/common/thrift/ImpalaService.thrift
File common/thrift/ImpalaService.thrift:

http://gerrit.cloudera.org:8080/#/c/22091/41/common/thrift/ImpalaService.thrift@1105
PS41, Line 1105:   // Occurrence threshold for using CTEs. CTEs are only used 
if occurrences are greater
               :   // than the threshold. Defaults to -1; negative values 
disable CTE planning.
               :   CTE_THRESHOLD = 205
> I chose this behavior to match Hive. It wouldn't be too hard to change.
I don't have a strong opinion on it. It took me a second to realize it was 
strictly greater, but that's fine.



--
To view, visit http://gerrit.cloudera.org:8080/22091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0840c0859d2fe25628d799a18d302cee1eb36e8
Gerrit-Change-Number: 22091
Gerrit-PatchSet: 41
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Stamatis Zampetakis <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Comment-Date: Thu, 13 Aug 2026 23:43:56 +0000
Gerrit-HasComments: Yes

Reply via email to