Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24629 )
Change subject: IMPALA-14618: Fix EventProcessor race with catalog reset ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/24629/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/24629/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@844 PS1, Line 844: public boolean removeTableIfNotAddedLater(long eventId, > Similar issue applicable for remove table. Since issue can add table and re I think remove table is fine since reset updates the createEventId to be larger than the DROP_TABLE event id. So we won't incorrectly remove an existing table here. Rename table event is split into a drop table and a create table event in HEP. If they are processed correctly, I think rename table is fine as well. I might have missed something, so let me know if you spot any broken cases. http://gerrit.cloudera.org:8080/#/c/24629/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@888 PS1, Line 888: public boolean addTableIfNotRemovedLater(long eventId, > We can similar issue for add table. Nice finding! I think this is an existing bug of applying stale CREATE_TABLE event which should be skipped by later DROP_TABLE event. Even without reset, we can reproduce it by manually restarting EP to a higher event id to skip the DROP_TABLE event while processing the CREATE_TABLE event. Fixed the race with reset in PS3. -- To view, visit http://gerrit.cloudera.org:8080/24629 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa0833c09cd7ec2461a0f2d1db7ab5a72ab6822b Gerrit-Change-Number: 24629 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 14 Aug 2026 14:53:47 +0000 Gerrit-HasComments: Yes
