Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24564 )
Change subject: IMPALA-15156: Fix CTE size metadata ...................................................................... IMPALA-15156: Fix CTE size metadata CTE and materialized-view rewrites can produce nested RelSubset inputs. Unwrapping only the outer input leaves child subsets in recursive size metadata, so Calcite may return a null average row size and assign infinite cost. Restore average-column-size metadata for RelSubset and delegate CTE consumer, producer, and sequence nodes to their underlying rels. Exclude FILTER_SCAN from the CTE materialization rules because it sends ImpalaCTEConsumer through SubstitutionVisitor, which cannot convert it to a mutable relational node. Add focused coverage for direct and nested RelSubset size metadata, CTE nodes, join costing, and aggregate costing. Testing: - git diff --check - calcite-planner and impala-package builds - TestImpalaRelMdNonCumulativeCost (5 tests) - Full test_cte_plans query set in a focused Linux environment - CTE runtime smoke for filter, aggregate, join, union, and nested shapes with num_nodes=1 and num_nodes=0 Change-Id: Ide226449f7b7a33fffd67f403b03fd5b2fee53ee Assisted-by: gpt-5.6-sol (OpenAI Codex) Reviewed-on: http://gerrit.cloudera.org:8080/24564 Reviewed-by: Joe McDonnell <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdSize.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java A java/calcite-planner/src/test/java/org/apache/impala/calcite/schema/TestImpalaRelMdNonCumulativeCost.java 3 files changed, 210 insertions(+), 8 deletions(-) Approvals: Joe McDonnell: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/24564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ide226449f7b7a33fffd67f403b03fd5b2fee53ee Gerrit-Change-Number: 24564 Gerrit-PatchSet: 12 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]>
