Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24690 )
Change subject: IMPALA-15256: Calcite planner returning wrong results for floor, ceil ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/24690/3/testdata/workloads/functional-query/queries/QueryTest/calcite.test File testdata/workloads/functional-query/queries/QueryTest/calcite.test: http://gerrit.cloudera.org:8080/#/c/24690/3/testdata/workloads/functional-query/queries/QueryTest/calcite.test@1393 PS3, Line 1393: ceil(-9.9), ceiling(-9.9), dceil(-9.9), dceil(cast(-9.9 as double)), I think a test that ceil(cast(-9.9 as double)) returns double would be more interesting. -- To view, visit http://gerrit.cloudera.org:8080/24690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I794cb181ebca59dae880eb96ae0f0570b5b9f8ed Gerrit-Change-Number: 24690 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 14 Aug 2026 19:44:33 +0000 Gerrit-HasComments: Yes
