Joe McDonnell has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/24695


Change subject: IMPALA-15188: Skip generating HTML profile diff for benchmark 
results
......................................................................

IMPALA-15188: Skip generating HTML profile diff for benchmark results

By default, report_benchmark_results.py produces an HTML profile
diff. For large profiles, this diff takes a long time to produce
and is difficult to use. Chrome struggles to display it even on
a local machine. This stops generating it by default and adds
the --generate_html_profile_diff option to manually turn it on.

For TPC-DS at scale, this makes a big difference:
Time with --generate_html_profile_diff:
real    9m19.840s
user    9m3.266s
sys     0m14.781s

Time without --generate_html_profile_diff:
real    0m31.230s
user    0m20.017s
sys     0m10.565s

Testing:
 - Ran on JSON files produced by the perf-AB-test job

Change-Id: Ie29cdff4a679a05b4816654256762edcca97e80d
---
M tests/benchmark/report_benchmark_results.py
1 file changed, 5 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/24695/1
--
To view, visit http://gerrit.cloudera.org:8080/24695
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie29cdff4a679a05b4816654256762edcca97e80d
Gerrit-Change-Number: 24695
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <[email protected]>

Reply via email to