Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24699 )
Change subject: IMPALA-15266: Fix flaky test due to slow Calcite first query. ...................................................................... Patch Set 3: (5 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24699/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java: http://gerrit.cloudera.org:8080/#/c/24699/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java@40 PS3, Line 40: import org.apache.calcite.sql2rel.SqlToRelConverter; unused import: org.apache.calcite.sql2rel.SqlToRelConverter http://gerrit.cloudera.org:8080/#/c/24699/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java@57 PS3, Line 57: ImpalaRelMetadataProvider.DEFAULT.revise(BuiltInMetadata.ExplainVisibility.Handler.class); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/24699/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java@61 PS3, Line 61: ImpalaRelMetadataProvider.DEFAULT.revise(BuiltInMetadata.DistinctRowCount.Handler.class); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24699/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java@64 PS3, Line 64: ImpalaRelMetadataProvider.DEFAULT.revise(BuiltInMetadata.CumulativeCost.Handler.class); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24699/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java@65 PS3, Line 65: ImpalaRelMetadataProvider.DEFAULT.revise(BuiltInMetadata.NonCumulativeCost.Handler.class); line too long (94 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90b167055cb8d8b0045344085083160f1d98f5a4 Gerrit-Change-Number: 24699 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 17 Aug 2026 12:28:55 +0000 Gerrit-HasComments: Yes
