Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24678 )
Change subject: IMPALA-15255: Fix test_invalidation_metrics flake with Calcite planner ...................................................................... Patch Set 3: Verified+1 Code-Review+2 Ok. I'll remove the "-1". Your changes definitely aren't harmful, so "-1" was perhaps a little extreme and my apologies for that. But I still am concerned that the flakiness won't go away with this. Using "Join" instead of "Union" definitely avoids some of the RelMetadataQuery initializations, so that will definitely help first query time. But the compilation times still seemed a bit high when I was testing, close to the one second mark with the "select count(*)". And that really isn't more complicated than the Union. That was the main reason for the "-1". I suppose I also viewed this more from the fact that this test now serves an unintended purpose of testing the fast initialization of the Calcite planner. But I suppose I don't have strong reasons to oppose this being merged in, especially since you've already gotten a +2 and it could solve the problem. -- To view, visit http://gerrit.cloudera.org:8080/24678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3298ea681f2a40bcd48eeadbf08b1c819c7e6765 Gerrit-Change-Number: 24678 Gerrit-PatchSet: 3 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 17 Aug 2026 15:31:23 +0000 Gerrit-HasComments: No
