Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24664 )
Change subject: IMPALA-15259: Update omake skill for ninja ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/24664/3/.agents/skills/build-one-cc-file/scripts/omake.sh File .agents/skills/build-one-cc-file/scripts/omake.sh: http://gerrit.cloudera.org:8080/#/c/24664/3/.agents/skills/build-one-cc-file/scripts/omake.sh@49 PS3, Line 49: ($IMPALA_MAKE_CMD DEBUG_NOOPT=1 -s -f "$MAKEFILE" "${MAKEFILE%/*}/$BASENAME.cc.o") This isn't actually enough. build.make doesn't exist, and the layout of build.ninja is different. -- To view, visit http://gerrit.cloudera.org:8080/24664 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1dc6211bec4a76fd1938749bd990d5bd890b4741 Gerrit-Change-Number: 24664 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 17 Aug 2026 16:29:26 +0000 Gerrit-HasComments: Yes
