Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24701 )
Change subject: Runtime filter pushdown? ...................................................................... Patch Set 1: (6 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24701/1/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/24701/1/fe/src/main/java/org/apache/impala/planner/PlanNode.java@68 PS1, Line 68: import org.apache.impala.thrift.TRuntimeFilterType; unused import: org.apache.impala.thrift.TRuntimeFilterType http://gerrit.cloudera.org:8080/#/c/24701/1/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/24701/1/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@150 PS1, Line 150: private final Map<PlanNodeId, List<CteConsumerFilterGroup>> cteConsumerFilterGroupsByCte_ = line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/24701/1/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@1262 PS1, Line 1262: .add(new CteConsumerFilterGroup((CTEConsumerNode) root, cteConsumerFilters)); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24701/1/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@1572 PS1, Line 1572: private void pushDownCteConsumerFiltersToScansRecursive(PlannerContext ctx, PlanNode node, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/24701/1/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@1584 PS1, Line 1584: private void assignCteConsumerFiltersToHdfsScan(PlannerContext ctx, HdfsScanNode scanNode, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/24701/1/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@1699 PS1, Line 1699: private Expr computeCteProducerTargetExpr(RuntimeFilter filter, CTEConsumerNode cteConsumer, line too long (94 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24701 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieda461b707203651308463c2a234d72f29e7dfbd Gerrit-Change-Number: 24701 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 17 Aug 2026 17:01:30 +0000 Gerrit-HasComments: Yes
