Impala Public Jenkins has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/24689 )
Change subject: IMPALA-15258: Fix race in buffer pool release
......................................................................
IMPALA-15258: Fix race in buffer pool release
target_dirty_bytes in buffer-pool can become negative, which causes the
while loop at the end of CleanPages to never terminate. This appears to
be a race condition in DestroyPageInternal, where we remove the page
from pinned_pages_ while holding lock_, then release the lock and later
update buffers_allocated_bytes_.
I20260812 22:48:09.199885 141206 buffer-pool.cc:679]
254fc219ed384ebf:227b64f700000010] target_dirty_bytes=-1048576
reservation=17825792 buffers_allocated_bytes_=1048576
pinned_pages_.bytes()=0 len=17825792
Change-Id: Ia247792cbcca24ad2caa82f9b8edc43ddeeaa4f3
Reviewed-on: http://gerrit.cloudera.org:8080/24689
Reviewed-by: Michael Smith <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
M be/src/runtime/bufferpool/buffer-pool.cc
1 file changed, 9 insertions(+), 1 deletion(-)
Approvals:
Michael Smith: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/24689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia247792cbcca24ad2caa82f9b8edc43ddeeaa4f3
Gerrit-Change-Number: 24689
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
