Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10895 )
Change subject: IMPALA-7129: Fixing path to UBSAN suppressions. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10895/2/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/10895/2/be/src/common/init.cc@306 PS2, Line 306: #define STRINGIFY(a) STRINGIFY_INTERNAL(a) > I'm trying to avoid using Substitute() or any other functions here so that What about embedding the quotes in the constant? -DUNDEFINED_SANITIZER_SUPPRESSIONS=\"$ENV{IMPALA_HOME}/bin/ubsan-suppressions.txt\"" If not: do you want to #if defined(STRINGIFY) #error? -- To view, visit http://gerrit.cloudera.org:8080/10895 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5295c2d1bddbea585a761b85a51eadecf10d191d Gerrit-Change-Number: 10895 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Tue, 10 Jul 2018 03:31:02 +0000 Gerrit-HasComments: Yes
