Nandor Kollar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24712 )
Change subject: IMPALA-13314: Cache HadoopCatalog instances and use holder pattern for singletons ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/24712/1/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/24712/1/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@187 PS1, Line 187: }; > The default case should remain. As we cover every possible case in the enum at the moment, the default is redundant. If we ever introduce a new catalog type, then this needs to be modified, but it will cause a compilation error (as switch expression needs to be exhaustive) if it is forgotten. The problem won't remain unnoticed. -- To view, visit http://gerrit.cloudera.org:8080/24712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb3a6c8e4f1d2a9e7c5b0f8d3e6a4c2b1d0e9f7a Gerrit-Change-Number: 24712 Gerrit-PatchSet: 2 Gerrit-Owner: Nandor Kollar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Wed, 19 Aug 2026 13:23:10 +0000 Gerrit-HasComments: Yes
