Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24577 )
Change subject: IMPALA-15178: Calcite Planner: support Iceberg time travel feature. ...................................................................... Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/24577/16/java/calcite-planner/src/main/java/org/apache/impala/calcite/util/JavaCCParserUtils.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/util/JavaCCParserUtils.java: http://gerrit.cloudera.org:8080/#/c/24577/16/java/calcite-planner/src/main/java/org/apache/impala/calcite/util/JavaCCParserUtils.java@67 PS16, Line 67: currentAbsoluteIndex += lineLength + 1; > Small thing about the arithmetic here: JavaCC treats \r\n as a single line Didn't really like the find/replace. I think I like finding the exact location a little better. -- To view, visit http://gerrit.cloudera.org:8080/24577 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ab3466d6c453f8e030763749dd64903b8c41264 Gerrit-Change-Number: 24577 Gerrit-PatchSet: 16 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 19 Aug 2026 15:50:13 +0000 Gerrit-HasComments: Yes
