Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24690 )
Change subject: IMPALA-15256: Calcite planner returning wrong results for floor, ceil ...................................................................... Patch Set 8: (5 comments) Sorry, couple small nits http://gerrit.cloudera.org:8080/#/c/24690/5/testdata/workloads/functional-query/queries/QueryTest/exprs.test File testdata/workloads/functional-query/queries/QueryTest/exprs.test: http://gerrit.cloudera.org:8080/#/c/24690/5/testdata/workloads/functional-query/queries/QueryTest/exprs.test@3440 PS5, Line 3440: DECIMAL,DOUBLE,DECIMAL,DOUBLE,DECIMAL,DOUBLE,DECIMAL,DOUB > Added new tests When I +2'd it, I forget I had this old comment on there. It's great to have the new tests though. http://gerrit.cloudera.org:8080/#/c/24690/8/testdata/workloads/functional-query/queries/QueryTest/exprs.test File testdata/workloads/functional-query/queries/QueryTest/exprs.test: http://gerrit.cloudera.org:8080/#/c/24690/8/testdata/workloads/functional-query/queries/QueryTest/exprs.test@3455 PS8, Line 3455: dtrunc(cast(-9.9 as double)) Nit: trunc rather than dtrunc (This is the same as the call one line below) http://gerrit.cloudera.org:8080/#/c/24690/8/testdata/workloads/functional-query/queries/QueryTest/exprs.test@3457 PS8, Line 3457: dtrunc(cast(9.9 as double)) Nit: trunc rather than dtrunc http://gerrit.cloudera.org:8080/#/c/24690/8/testdata/workloads/functional-query/queries/QueryTest/exprs.test@3466 PS8, Line 3466: round(-9.9), dround(-9.9), dround(cast(-9.9 as double)), : round(9.9), dround(9.9), dround(cast(9.9 as double)) Let's add round(cast(X as double)) variants. http://gerrit.cloudera.org:8080/#/c/24690/8/testdata/workloads/functional-query/queries/QueryTest/exprs.test@3475 PS8, Line 3475: round(-9.78, 1), dround(-9.78, 1), dround(cast(-9.78 as double), 1), : round(9.78, 1), dround(9.78, 1), dround(cast(9.78 as double), 1) Let's add round(cast(X as double)) variants. -- To view, visit http://gerrit.cloudera.org:8080/24690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I794cb181ebca59dae880eb96ae0f0570b5b9f8ed Gerrit-Change-Number: 24690 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 20 Aug 2026 20:58:44 +0000 Gerrit-HasComments: Yes
