Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24691 )
Change subject: IMPALA-15261: Calcite Planner: Fix broken tests due to plan changes. ...................................................................... Patch Set 4: (1 comment) One question about the straight_join hint. http://gerrit.cloudera.org:8080/#/c/24691/4/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/24691/4/tests/query_test/test_iceberg.py@1292 PS4, Line 1292: select /*+ straight_join */ i_product_name, i_brand, i_class, i_category, One thought on the hint: the loop below skips zeros ("if files_rejected != 0"), so if the fixed join order changes which runtime filters fire, the check can end up comparing nothing and still pass. Did the counts stay non-zero with straight_join on both planners? If they did, maybe assert that at least one value is non-zero, so the test cannot quietly go vacuous later. -- To view, visit http://gerrit.cloudera.org:8080/24691 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77683c0ab2f506b6c638255b63bde243b33dd8fb Gerrit-Change-Number: 24691 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Sun, 23 Aug 2026 13:59:28 +0000 Gerrit-HasComments: Yes
