Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24665 )
Change subject: IMPALA-15243: Fix costing for CTEs ...................................................................... Patch Set 19: (1 comment) One thing I noticed after the merge, in cte-distributed.test. http://gerrit.cloudera.org:8080/#/c/24665/19/testdata/workloads/functional-query/queries/QueryTest/cte-distributed.test File testdata/workloads/functional-query/queries/QueryTest/cte-distributed.test: http://gerrit.cloudera.org:8080/#/c/24665/19/testdata/workloads/functional-query/queries/QueryTest/cte-distributed.test@136 PS19, Line 136: '| 02:SCAN HDFS [test_cte_distributed_65ce44fd.emps, RANDOM]' Noticed this after the merge, while reading 24657 on top of it: these six lines pin the unique database name, where the file used $DATABASE before. The name is <test function>_<crc32 of the full pytest id>, so it only holds as long as that id does - an exhaustive run has disable_codegen True and False, which is two ids and two databases, so at most one of them can match; a rename or a move would do the same. Core runs have a single vector, which is why CI is green. Putting $DATABASE back into those lines should be all it takes - it could even ride along in 24657 if you'd rather not spin a separate patch. -- To view, visit http://gerrit.cloudera.org:8080/24665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21b60af313070029a1fa8bf835107bef88f54912 Gerrit-Change-Number: 24665 Gerrit-PatchSet: 19 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Stamatis Zampetakis <[email protected]> Gerrit-Comment-Date: Sun, 23 Aug 2026 14:27:01 +0000 Gerrit-HasComments: Yes
