Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24699 )
Change subject: IMPALA-15266: Fix flaky test due to slow Calcite first query. ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/24699/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java: http://gerrit.cloudera.org:8080/#/c/24699/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java@55 PS5, Line 55: ImpalaRelMetadataProvider.DEFAULT.revise( > I think it's fine. Memory-wise I'm convinced. What I still can't tell is the startup cost: after the move every impalad pays that compilation while starting, Calcite or not. Do you have a number from a restart? If it turns out to be a noticeable slice of that second, a background thread would give you both. http://gerrit.cloudera.org:8080/#/c/24699/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java@76 PS5, Line 76: RelMetadataQuery.THREAD_PROVIDERS.set( > Removed the code Checked on PS7 - every metadata query in the module comes from the cluster, and the provider is set in CalciteRelNodeConverter, so nothing is left on the thread-local. Thanks! http://gerrit.cloudera.org:8080/#/c/24699/5/tests/custom_cluster/test_automatic_invalidation.py File tests/custom_cluster/test_automatic_invalidation.py: http://gerrit.cloudera.org:8080/#/c/24699/5/tests/custom_cluster/test_automatic_invalidation.py@256 PS5, Line 256: self.execute_query("select 1") > Filed IMPALA-15283 as a catch-all to find these. Thanks for filing IMPALA-15283. -- To view, visit http://gerrit.cloudera.org:8080/24699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90b167055cb8d8b0045344085083160f1d98f5a4 Gerrit-Change-Number: 24699 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Sun, 23 Aug 2026 17:09:10 +0000 Gerrit-HasComments: Yes
