Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24260 )
Change subject: IMPALA-14946: Catch "trunc" error within Calcite planner ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/24260/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaAdjustScaleFunction.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaAdjustScaleFunction.java: http://gerrit.cloudera.org:8080/#/c/24260/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaAdjustScaleFunction.java@63 PS2, Line 63: throw new RuntimeException("Invalid Truncate Unit for scale"); > Thanks. Could you add the two cast cases to the test? cast(1 as int) is the I recently learned about exprs-test, and this seems like a good fit there. This currently does not run with Calcite Planner. And it doesn't work with Calcite Planner either. But this will be part of the Calcite test build in an upcoming commit, prolly within the next week or two. -- To view, visit http://gerrit.cloudera.org:8080/24260 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I766c138fae027ba0d919daa5cce38dc93d7144d1 Gerrit-Change-Number: 24260 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 25 Aug 2026 14:54:44 +0000 Gerrit-HasComments: Yes
