Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24755 )
Change subject: IMPALA-15144: Fetch and store credentials from REST catalog ...................................................................... Patch Set 1: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24755/1/fe/src/test/java/org/apache/impala/catalog/iceberg/translate/ConfigTranslatorTest.java File fe/src/test/java/org/apache/impala/catalog/iceberg/translate/ConfigTranslatorTest.java: http://gerrit.cloudera.org:8080/#/c/24755/1/fe/src/test/java/org/apache/impala/catalog/iceberg/translate/ConfigTranslatorTest.java@89 PS1, Line 89: assertEquals("none", translate(rule, ImmutableMap.of("session", "none")).get("session")); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24755/1/fe/src/test/java/org/apache/impala/catalog/iceberg/translate/ConfigTranslatorTest.java@124 PS1, Line 124: Map<String, String> out = translate(rule, ImmutableMap.of("adls.sas-token.acct1", "TOKEN")); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/24755/1/fe/src/test/java/org/apache/impala/catalog/iceberg/translate/ConfigTranslatorTest.java@171 PS1, Line 171: new TranslationRule.RenameRule("uri"), ImmutableMap.of("uri", "x", "unknown", "y")); line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d9c6e97e17fe8ad6304b49b07fd047cc2a3ffbe Gerrit-Change-Number: 24755 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 26 Aug 2026 12:48:18 +0000 Gerrit-HasComments: Yes
