Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10758 )
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/10758/9/be/src/kudu/util/kudu_export.h File be/src/kudu/util/kudu_export.h: http://gerrit.cloudera.org:8080/#/c/10758/9/be/src/kudu/util/kudu_export.h@17 PS9, Line 17: > A note would be good but feel free to merge it as-is. Just checking to see I will push a note in a final rebase once the last change has been reviewed, since it will require me to carry all +2s. // This file is generated during Kudu's build. Instead of recreating the necessary steps // in Impala's build process, we copy it into our repository. See // kudu/client/CMakeLists.txt in Kudu's repository for details. -- To view, visit http://gerrit.cloudera.org:8080/10758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I451f02d3e4669e8a548b92fb1445cb2b322659a2 Gerrit-Change-Number: 10758 Gerrit-PatchSet: 9 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Comment-Date: Wed, 11 Jul 2018 05:58:42 +0000 Gerrit-HasComments: Yes
