Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/24190 )
Change subject: IMPALA-14882: part1: Convert arrow record batch to impala tuple batch ...................................................................... Patch Set 33: (1 comment) http://gerrit.cloudera.org:8080/#/c/24190/31/be/src/exec/arrow-converter.h File be/src/exec/arrow-converter.h: http://gerrit.cloudera.org:8080/#/c/24190/31/be/src/exec/arrow-converter.h@48 PS31, Line 48: void** raw_values, uint8_t* value_buffer, const ColumnType& type, MemPool* mem_pool, > How about returning an error if the type of the `array` argument does not m I added an error status for this and a test case in arrow-converter-test. -- To view, visit http://gerrit.cloudera.org:8080/24190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea544b3c71d9211c893f0fec3527ebe84155ebcd Gerrit-Change-Number: 24190 Gerrit-PatchSet: 33 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Reviewer: jichen <[email protected]> Gerrit-Comment-Date: Mon, 31 Aug 2026 11:10:55 +0000 Gerrit-HasComments: Yes
