Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24703 )
Change subject: IMPALA-14686: Use long polling by default ...................................................................... IMPALA-14686: Use long polling by default Long polling avoids extra latency on short queries by waiting for completion on the server side rather than sleep on the client side. This has a very large effect on short queries, as the client may sleep 50ms when waiting for completion. This is more efficient than short polling intervals. This sets the default value of long_polling_time_ms to 250ms. This allows for relatively quick cancellation for interactive clients like impala-shell, but it waits enough time to avoid excessive wait for small queries. There were a few tests that needed adjustments to work with long polling: - TestAsyncDDLTiming.test_alter_table_recover is checking that a certain query waits a specific amount of time. The start timestamp was taken after a call that would use long polling, so this was throwing off the time. This moved the start timestamp to before the long polling. - test_admission_control.py's test_kill_statestore_with_queries_running and test_kill_coord_with_queries_running were using queries that reached the FINISHED state very quickly. With long polling, the client never saw them in RUNNING state. This changes the query so that it stays in the RUNNING state longer and avoids the issue. - TestEventSyncFailures's test_hms_event_sync_with_event_processing_disabled sees a timing window where the get_log() does not include the INJECT_ERROR_LOG. This is a race condition between the transition to FINISHED and ClientRequestState setting the coordinator (which includes the error log). This changes the test to add a fetch call, which avoids the timing window. Testing: - Passed an exhaustive release job Change-Id: I73c23e735a51b56c94687b18894d01f605287a4b Reviewed-on: http://gerrit.cloudera.org:8080/24703 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Michael Smith <[email protected]> --- M common/thrift/ImpalaService.thrift M common/thrift/Query.thrift M tests/custom_cluster/test_admission_controller.py M tests/custom_cluster/test_events_custom_configs.py M tests/metadata/test_ddl.py 5 files changed, 22 insertions(+), 5 deletions(-) Approvals: Impala Public Jenkins: Verified Michael Smith: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/24703 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I73c23e735a51b56c94687b18894d01f605287a4b Gerrit-Change-Number: 24703 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
