Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24771 )
Change subject: IMPALA-15218: Add trusted_jar_paths for data sources ...................................................................... Patch Set 1: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24771/1/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/24771/1/be/src/service/frontend.cc@115 PS1, Line 115: "for JDBC data source tables, or the LOCATION for external data source tables, starts " line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24771/1/fe/src/test/java/org/apache/impala/extdatasource/jdbc/JdbcDataSourceTest.java File fe/src/test/java/org/apache/impala/extdatasource/jdbc/JdbcDataSourceTest.java: http://gerrit.cloudera.org:8080/#/c/24771/1/fe/src/test/java/org/apache/impala/extdatasource/jdbc/JdbcDataSourceTest.java@70 PS1, Line 70: // FILESYSTEM_PREFIX/test-warehouse/data-sources/,DEFAULT_FS/test-warehouse/data-sources/ line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24771/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/24771/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@66 PS1, Line 66: // FILESYSTEM_PREFIX/test-warehouse/data-sources/,DEFAULT_FS/test-warehouse/data-sources/ line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24771/1/fe/src/test/java/org/apache/impala/service/BackendConfigTest.java File fe/src/test/java/org/apache/impala/service/BackendConfigTest.java: http://gerrit.cloudera.org:8080/#/c/24771/1/fe/src/test/java/org/apache/impala/service/BackendConfigTest.java@103 PS1, Line 103: public void testIsJarPathAllowed_pathContainsPrefixButDoesNotStartWithIt_returnsFalse() { line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: branch-4.5.2 Gerrit-MessageType: comment Gerrit-Change-Id: I0bf53fb5eff545d5584ca120e362fd01a2086be1 Gerrit-Change-Number: 24771 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 31 Aug 2026 19:38:02 +0000 Gerrit-HasComments: Yes
