Anubhav Jindal has posted comments on this change. ( http://gerrit.cloudera.org:8080/24448 )
Change subject: IMPALA-14799: Add oauth_servers support and tests ...................................................................... Patch Set 21: (2 comments) Done http://gerrit.cloudera.org:8080/#/c/24448/20/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/24448/20/be/src/util/webserver.cc@763 PS20, Line 763: if (use_jwt_ || use_oauth_) { > We can remove this comment since we are using the unified interface now. An Done http://gerrit.cloudera.org:8080/#/c/24448/20/be/src/util/webserver.cc@782 PS20, Line 782: // imperfect because OAuthTokenAuth() uses unified verification and : // doesn't return which provider matched. A follow-up should retu > This comment is a bit confusing because it mixes the metrics logic with the Done -- To view, visit http://gerrit.cloudera.org:8080/24448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib29ff36600406ba59c10f29d79cc632020f4a3f7 Gerrit-Change-Number: 24448 Gerrit-PatchSet: 21 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 02 Sep 2026 04:32:16 +0000 Gerrit-HasComments: Yes
