Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23237 )
Change subject: IMPALA-14285: Add SAML2 authentication support for Coordinator Web UI ...................................................................... Patch Set 29: (5 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23237/29/fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlAuthTokenGenerator.java File fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlAuthTokenGenerator.java: http://gerrit.cloudera.org:8080/#/c/23237/29/fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlAuthTokenGenerator.java@32 PS29, Line 32: // https://github.com/vihangk1/hive/blob/d0209a6f026106622523bd4ec7eeeae33782e7a3/service/src/java/org/apache/hive/service/auth/saml/HiveSamlAuthTokenGenerator.java line too long (164 > 90) http://gerrit.cloudera.org:8080/#/c/23237/29/fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlRelayStateInfoHS2.java File fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlRelayStateInfoHS2.java: http://gerrit.cloudera.org:8080/#/c/23237/29/fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlRelayStateInfoHS2.java@20 PS29, Line 20: // based on https://github.com/vihangk1/hive/blob/45863cc1fc94c2f2a848d0f3fc160a4dc0214747/service/src/java/org/apache/hive/service/auth/saml/HiveSamlRelayStateInfo.java line too long (169 > 90) http://gerrit.cloudera.org:8080/#/c/23237/29/fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlRelayStateStoreHS2.java File fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlRelayStateStoreHS2.java: http://gerrit.cloudera.org:8080/#/c/23237/29/fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlRelayStateStoreHS2.java@24 PS29, Line 24: // based on https://github.com/vihangk1/hive/blob/45863cc1fc94c2f2a848d0f3fc160a4dc0214747/service/src/java/org/apache/hive/service/auth/saml/HiveSamlRelayStateStore.java line too long (170 > 90) http://gerrit.cloudera.org:8080/#/c/23237/29/fe/src/main/java/org/apache/impala/authentication/saml/ImpalaSamlClientHS2.java File fe/src/main/java/org/apache/impala/authentication/saml/ImpalaSamlClientHS2.java: http://gerrit.cloudera.org:8080/#/c/23237/29/fe/src/main/java/org/apache/impala/authentication/saml/ImpalaSamlClientHS2.java@32 PS29, Line 32: // based on https://github.com/vihangk1/hive/blob/d0209a6f026106622523bd4ec7eeeae33782e7a3/service/src/java/org/apache/hive/service/auth/saml/HiveSaml2Client.java line too long (162 > 90) http://gerrit.cloudera.org:8080/#/c/23237/29/fe/src/main/java/org/apache/impala/authentication/saml/ImpalaSamlClientHS2.java@143 PS29, Line 143: // https://github.com/vihangk1/hive/blob/d0209a6f026106622523bd4ec7eeeae33782e7a3/service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java line too long (158 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12540300529f9c240abf7196141ecb0ae6e37995 Gerrit-Change-Number: 23237 Gerrit-PatchSet: 29 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 02 Sep 2026 17:17:57 +0000 Gerrit-HasComments: Yes
