Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24685 )
Change subject: IMPALA-15239: Remove the HMS server from Catalog server ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/24685/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24685/3//COMMIT_MSG@11 PS3, Line 11: is not actively used by the : community. > It'd be nice to send a [DISCUSS]/[VOTE] email about this in the dev mailing I will send an email to the dev mailing list soon. http://gerrit.cloudera.org:8080/#/c/24685/3/fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java File fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java: http://gerrit.cloudera.org:8080/#/c/24685/3/fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java@125 PS3, Line 125: if (params != null && !params.isEmpty()) { > Do we need this somewhere? We probably don't need this change. createHmsDatabaseObject() is only used by createDatabase() in this file. I will remove the changes to this file in the next patch. -- To view, visit http://gerrit.cloudera.org:8080/24685 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I377a8ce0890055533ab7c78920ec17d6b47653b3 Gerrit-Change-Number: 24685 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 02 Sep 2026 23:36:05 +0000 Gerrit-HasComments: Yes
