Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24787 )
Change subject: IMPALA-15327: CTE rewrite algorithm cannot explore all suggestions ...................................................................... Patch Set 2: (3 comments) This really only updates the plan for 1 query? http://gerrit.cloudera.org:8080/#/c/24787/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24787/2//COMMIT_MSG@9 PS2, Line 9: The rewrite algorithm relies on the MaterializedViewRule hierarchy. In I updated some commit formatting and fixed a typo. http://gerrit.cloudera.org:8080/#/c/24787/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdAllPredicates.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdAllPredicates.java: http://gerrit.cloudera.org:8080/#/c/24787/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdAllPredicates.java@36 PS2, Line 36: return null; Can you add a comment somewhere why returning null is the appropriate action for this and the other handlers? http://gerrit.cloudera.org:8080/#/c/24787/2/testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cte/tpcds-q75.test File testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cte/tpcds-q75.test: http://gerrit.cloudera.org:8080/#/c/24787/2/testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cte/tpcds-q75.test@80 PS2, Line 80: Per-Host Resource Estimates: Memory=199.45GB Unrelated, I've seen the CTE plans seem to increase the per-host resource estimates. We should look into that at some point. -- To view, visit http://gerrit.cloudera.org:8080/24787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic32d11cd82e2484944b6d03d5fb56900e8e1b7a4 Gerrit-Change-Number: 24787 Gerrit-PatchSet: 2 Gerrit-Owner: Stamatis Zampetakis <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 03 Sep 2026 16:25:09 +0000 Gerrit-HasComments: Yes
