Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24608 )
Change subject: IMPALA-15175: Support HBO for AnalyticEvalNode cardinality ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/24608/4/fe/src/main/java/org/apache/impala/planner/AnalyticEvalNode.java File fe/src/main/java/org/apache/impala/planner/AnalyticEvalNode.java: http://gerrit.cloudera.org:8080/#/c/24608/4/fe/src/main/java/org/apache/impala/planner/AnalyticEvalNode.java@357 PS4, Line 357: // below the analytic), their columns are qualified with the join's canonical operand > limit_ is missing from the key. An AnalyticEvalNode can carry a limit: for Done. Added a test for LIMIT. http://gerrit.cloudera.org:8080/#/c/24608/4/fe/src/main/java/org/apache/impala/planner/AnalyticEvalNode.java@380 PS4, Line 380: orderStrs.add(ob.toString()); > getNullsFirstParam() is the raw parse-level value (null when unspecified), Done. Added testAnalyticImplicitAndExplicitNullsMatch for this. http://gerrit.cloudera.org:8080/#/c/24608/6/fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java File fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java: http://gerrit.cloudera.org:8080/#/c/24608/6/fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java@1343 PS6, Line 1343: int count = 0; > These `a.` and `b.` are the query's aliases, and they land inside the HBO k This is indeed a bug. Fixed in -- To view, visit http://gerrit.cloudera.org:8080/24608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d87ab472db9273622f48fa62bb1d8c12e04e86b Gerrit-Change-Number: 24608 Gerrit-PatchSet: 7 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 04 Sep 2026 08:42:59 +0000 Gerrit-HasComments: Yes
