Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10769 )
Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes ...................................................................... Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/10769/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10769/14//COMMIT_MSG@11 PS14, Line 11: Rename constants > Can you please also specify the commit (e719b5ef) ? Will do in final push. - Rename constants (Kudu commit e719b5ef) http://gerrit.cloudera.org:8080/#/c/10769/14/be/src/gutil/strings/substitute.cc File be/src/gutil/strings/substitute.cc: http://gerrit.cloudera.org:8080/#/c/10769/14/be/src/gutil/strings/substitute.cc@15 PS14, Line 15: > Is the change in gutil/strings/escaping.cc missing ?(https://github.com/apa I only picked those parts of that commit that had an effect on Impala's code, notably renaming NoArg to kNoArg. Parts that didn't affect Impala's inclusion of the Kudu code were left for a later, proper rebase of gutil. Not picking this commit at all would have meant to undo parts of it in Kudu's code. -- To view, visit http://gerrit.cloudera.org:8080/10769 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb Gerrit-Change-Number: 10769 Gerrit-PatchSet: 14 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Wed, 11 Jul 2018 21:14:51 +0000 Gerrit-HasComments: Yes
