Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24579 )

Change subject: IMPALA-15139: Support DELTA_LENGTH_BYTE_ARRAY Parquet encoding
......................................................................


Patch Set 19: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24579/16/be/src/benchmarks/parquet-delta-length-byte-array-benchmark.cc
File be/src/benchmarks/parquet-delta-length-byte-array-benchmark.cc:

http://gerrit.cloudera.org:8080/#/c/24579/16/be/src/benchmarks/parquet-delta-length-byte-array-benchmark.cc@31
PS16, Line 31: //    all-long   146 iters/ms   1X      (zero-copy: only pointer 
stored, no Smallify)
             : //    mixed M-L  137 iters/ms   0.94X   (short-first phase: 
S,L,S,L)
> Did some experiments on this. The deviation comes purely from the ORDER of
>core warms up to its full turbo frequency 

note that we should do tests without turbo (making them slower)

this is what I do before running benchmarks on my Ubuntu:
echo 1 | sudo tee /sys/devices/system/cpu/intel_pstate/no_turbo
echo performance | sudo tee 
/sys/devices/system/cpu/cpu*/cpufreq/scaling_governor

and this is how I switch back to normal operation:
echo 0 | sudo tee /sys/devices/system/cpu/intel_pstate/no_turbo
echo powersave | sudo tee /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor



--
To view, visit http://gerrit.cloudera.org:8080/24579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e4395fa30cd7fb2c89ef5a2b16b043d4de60b52
Gerrit-Change-Number: 24579
Gerrit-PatchSet: 19
Gerrit-Owner: Mihaly Szjatinya <[email protected]>
Gerrit-Reviewer: Balazs Hevele <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Mihaly Szjatinya <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Wed, 09 Sep 2026 15:04:11 +0000
Gerrit-HasComments: Yes

Reply via email to