Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24793 )
Change subject: IMPALA-15338: Plan a TIMESTAMP literal in a VALUES row ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/24793/2/fe/src/main/java/org/apache/impala/planner/UnionNode.java File fe/src/main/java/org/apache/impala/planner/UnionNode.java: http://gerrit.cloudera.org:8080/#/c/24793/2/fe/src/main/java/org/apache/impala/planner/UnionNode.java@105 PS2, Line 105: public List<List<Expr>> getConstExprLists() { return constExprLists_; } Slightly torn here, I'll leave it up to you to decide: constExprLists_ is not declared as immutable, so theoretically a caller can change it. Since it's only being used in the test environment (hopefully forever), maybe it's worth a copy and add a comment to say that it's inefficient? Or maybe just leave it as/is, since that is a bit too much nitpicking and overkill to keep as immutable as possible? -- To view, visit http://gerrit.cloudera.org:8080/24793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If8b5eebe9b5fa94066ff2f9410cab799fc6a3497 Gerrit-Change-Number: 24793 Gerrit-PatchSet: 2 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 10 Sep 2026 14:27:10 +0000 Gerrit-HasComments: Yes
