Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24784 )
Change subject: IMPALA-15324: Size exchange memory on input rows ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/24784/2/fe/src/main/java/org/apache/impala/planner/ExchangeNode.java File fe/src/main/java/org/apache/impala/planner/ExchangeNode.java: http://gerrit.cloudera.org:8080/#/c/24784/2/fe/src/main/java/org/apache/impala/planner/ExchangeNode.java@331 PS2, Line 331: ddCardinalities( > Yes, but only without a limit, and there `LIMIT+OFFSET` is not available ei That makes sense. http://gerrit.cloudera.org:8080/#/c/24784/3/fe/src/main/java/org/apache/impala/planner/ExchangeNode.java File fe/src/main/java/org/apache/impala/planner/ExchangeNode.java: http://gerrit.cloudera.org:8080/#/c/24784/3/fe/src/main/java/org/apache/impala/planner/ExchangeNode.java@324 PS3, Line 324: Not the filtered : // cardinality, since this bounds what can be buffered and a late or non-selective : // runtime filter still leaves the full stream in the queues. nit: this can be moved down on L328 to explain why not using getFilteredCardinality(). http://gerrit.cloudera.org:8080/#/c/24784/3/fe/src/main/java/org/apache/impala/planner/ExchangeNode.java@331 PS3, Line 331: MathUtil.addCardinalities(limit_, offset_) When offset_ == -1 but limt_ is valid, this returns -1. I think we should use limit_ in such case. http://gerrit.cloudera.org:8080/#/c/24784/3/fe/src/main/java/org/apache/impala/planner/ExchangeNode.java@361 PS3, Line 361: (double) nit: getAvgRowSize() returns a float type. Why do we need this cast for rowsReachingQueues? -- To view, visit http://gerrit.cloudera.org:8080/24784 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ab880549e63267f97b2c193cf76aa92bbfc581c Gerrit-Change-Number: 24784 Gerrit-PatchSet: 3 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 11 Sep 2026 01:35:18 +0000 Gerrit-HasComments: Yes
