Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/24812 )
Change subject: IMPALA-15343: Add thrift 0.24.0 ...................................................................... Patch Set 2: Code-Review+1 (2 comments) The code looks fine to me, patches (removed and retained) look reasonable; added a couple of nits for the commit message. http://gerrit.cloudera.org:8080/#/c/24812/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24812/2//COMMIT_MSG@20 PS2, Line 20: injecting a pre-built SSL_CTX nit: It would be great if you could add the Impala change (ticket ref or commit hash) that added the change. http://gerrit.cloudera.org:8080/#/c/24812/2//COMMIT_MSG@21 PS2, Line 21: thrift nit: I believe Thrift should be capitalized here. -- To view, visit http://gerrit.cloudera.org:8080/24812 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2228333e05d3f9009387406a96384098180c13d7 Gerrit-Change-Number: 24812 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Comment-Date: Fri, 11 Sep 2026 17:01:30 +0000 Gerrit-HasComments: Yes
