Peter Rozsa has uploaded this change for review. (
http://gerrit.cloudera.org:8080/24837
Change subject: IMPALA-15347: Move static S3 credential handling into
S3ConnCredentials
......................................................................
IMPALA-15347: Move static S3 credential handling into S3ConnCredentials
Extracts the --s3a_access_key_cmd / --s3a_secret_key_cmd handling out of
HdfsFsCache into a new S3ConnCredentials class. The flags and the
command execution now live in s3-conn-credentials.{h,cc}; Init() runs
once at daemon startup (after HdfsFsCache::Init()) and stores the result
as a generic fs.s3a.* config map. HdfsFsCache::GetConnection() consumes
that map when building a connection instead of two ad-hoc static strings.
Behaviour is unchanged: setting only one of the two flags is still
ignored (now with a warning), and so is a command that succeeds but
prints nothing, so the keys in the Hadoop client configuration are never
overridden with empty ones. The secret-key error message previously
said "Access Key"; it now says "Secret Key".
This prepares HdfsFsCache for taking per-query vended credentials in the
same map form.
Change-Id: Ie48cbb0c313f32242c4fce6603eab3e54d08cabd
Co-Authored-By: Claude Fable 5.1 <[email protected]>
---
M be/src/common/init.cc
M be/src/runtime/CMakeLists.txt
M be/src/runtime/hdfs-fs-cache.cc
M be/src/runtime/hdfs-fs-cache.h
A be/src/runtime/s3-conn-credentials.cc
A be/src/runtime/s3-conn-credentials.h
6 files changed, 152 insertions(+), 43 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/24837/1
--
To view, visit http://gerrit.cloudera.org:8080/24837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie48cbb0c313f32242c4fce6603eab3e54d08cabd
Gerrit-Change-Number: 24837
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <[email protected]>
