Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24838 )

Change subject: IMPALA-15145: Propagate credential metadata to Scan Nodes / 
Execution Plan
......................................................................


Patch Set 1:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24838/1/fe/src/main/java/org/apache/impala/catalog/iceberg/VendedCredentialsFileIO.java
File 
fe/src/main/java/org/apache/impala/catalog/iceberg/VendedCredentialsFileIO.java:

http://gerrit.cloudera.org:8080/#/c/24838/1/fe/src/main/java/org/apache/impala/catalog/iceberg/VendedCredentialsFileIO.java@72
PS1, Line 72:   private static final Logger LOG = 
LoggerFactory.getLogger(VendedCredentialsFileIO.class);
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/24838/1/fe/src/main/java/org/apache/impala/catalog/iceberg/VendedCredentialsFileIO.java@153
PS1, Line 153:     usable.sort((a, b) -> 
Integer.compare(b.getPrefix().length(), a.getPrefix().length()));
line too long (91 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/24838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73592a1521f29374316ed001341f956b40f9c0d5
Gerrit-Change-Number: 24838
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Mon, 14 Sep 2026 10:41:45 +0000
Gerrit-HasComments: Yes

Reply via email to