Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )
Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/24821/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24821/7//COMMIT_MSG@11 PS7, Line 11: Impala) inheriting from TCLIService (coming from Hive). Add > nit: capitalization is inconsistent. Done http://gerrit.cloudera.org:8080/#/c/24821/7/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/24821/7/fe/pom.xml@1077 PS7, Line 1077: <artifactId>hive-service-rpc</artifactId> > Should we add a rule to maven-enforcer-plugin? It seems that it is not that easy, because the version pinning rule's include rule: <include>org.apache.hive:*:${hive.version}</include> Create a patch to separate version/artifact exclusion, with that it would be easy to add such rule: https://gerrit.cloudera.org/#/c/24846/ I didn't want to do that change in this patch. -- To view, visit http://gerrit.cloudera.org:8080/24821 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2 Gerrit-Change-Number: 24821 Gerrit-PatchSet: 8 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 15 Sep 2026 09:14:39 +0000 Gerrit-HasComments: Yes
