Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24814 )

Change subject: IMPALA-15354: bump Thrift to 0.24.0 - C++ parts
......................................................................


Patch Set 5:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24814/5/be/src/rpc/thrift-util.cc
File be/src/rpc/thrift-util.cc:

http://gerrit.cloudera.org:8080/#/c/24814/5/be/src/rpc/thrift-util.cc@127
PS5, Line 127: // 
https://github.com/apache/thrift/blob/release/0.24.0/lib/cpp/src/thrift/transport/TSSLSocket.cpp#L182
line too long (104 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/24814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieea10df03996fef64ea25f51c9e5e4e47c8cefa1
Gerrit-Change-Number: 24814
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Tue, 15 Sep 2026 10:38:21 +0000
Gerrit-HasComments: Yes

Reply via email to