Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24818 )
Change subject: IMPALA-15033: Optimize simple LIMIT queries on Iceberg V2 tables ...................................................................... Patch Set 1: (4 comments) Please add an e2e test that validates the limit > availableNonDeleteRows. http://gerrit.cloudera.org:8080/#/c/24818/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/24818/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@364 PS1, Line 364: private PlanNode trySimpleLimitOptimization() throws ImpalaException { I'd move this method to a stateless class to decrease the clutter in this already-cluttered planner class. It might return an optional, and the based on the value the control could branch. http://gerrit.cloudera.org:8080/#/c/24818/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@365 PS1, Line 365: if (tblRef_.getSelectedDataFilesForOptimize() != null) return null; I think this goes for OPTIMIZE statement, logically this should not be here. I wonder if we can eliminate that method sometime as it is really oddly placed and named http://gerrit.cloudera.org:8080/#/c/24818/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@388 PS1, Line 388: ret.init(analyzer_); If the optimization is successful, all a planner event that logs it. http://gerrit.cloudera.org:8080/#/c/24818/1/testdata/workloads/functional-planner/queries/PlannerTest/iceberg-optimize-simple-limit.test File testdata/workloads/functional-planner/queries/PlannerTest/iceberg-optimize-simple-limit.test: http://gerrit.cloudera.org:8080/#/c/24818/1/testdata/workloads/functional-planner/queries/PlannerTest/iceberg-optimize-simple-limit.test@1 PS1, Line 1: IMPALA-13652 nit: wrong ticket id -- To view, visit http://gerrit.cloudera.org:8080/24818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I416d947e3c6e3fb0e4c2da056d75f70c08ac9676 Gerrit-Change-Number: 24818 Gerrit-PatchSet: 1 Gerrit-Owner: Nandor Kollar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 15 Sep 2026 13:16:15 +0000 Gerrit-HasComments: Yes
