Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24706 )
Change subject: IMPALA-14752: Support W3C trace context propagation for hs2-http ...................................................................... Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/24706/4/be/src/transport/THttpServer.cpp File be/src/transport/THttpServer.cpp: http://gerrit.cloudera.org:8080/#/c/24706/4/be/src/transport/THttpServer.cpp@151 PS4, Line 151: const std::string THttpServer::HEADER_TRACEPARENT = "traceparent"; Minor note: browser-based hs2-http clients cannot send the new W3C trace headers cross-origin. The server parses traceparent and tracestate, but its CORS preflight response still allows only Content-Type in THttpServer.cpp:264-266. Since these headers are not CORS-safelisted, browsers will reject the actual POST after preflight. Could be fixed by adding traceparent,tracestate to Access-Control-Allow-Headers, but we don't actually expect browsers to interact over hs2-http. -- To view, visit http://gerrit.cloudera.org:8080/24706 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieac548f4f5f613ba116d1a79d95e31b7a1a37b97 Gerrit-Change-Number: 24706 Gerrit-PatchSet: 4 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 15 Sep 2026 16:47:33 +0000 Gerrit-HasComments: Yes
