Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24557 )
Change subject: IMPALA-15057: Add variant_get() builtin and first-class VARIANT expressions ...................................................................... Patch Set 10: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/24557/10/be/src/runtime/variant-value.cc File be/src/runtime/variant-value.cc: http://gerrit.cloudera.org:8080/#/c/24557/10/be/src/runtime/variant-value.cc@424 PS10, Line 424: index = index * 10 + (*p - '0'); Integer overflow on [100000000000000000000] http://gerrit.cloudera.org:8080/#/c/24557/10/be/src/util/variant-util.h File be/src/util/variant-util.h: http://gerrit.cloudera.org:8080/#/c/24557/10/be/src/util/variant-util.h@48 PS10, Line 48: Status VariantSlotToJson(const VariantSlot* slot, std::string* json_out); nit: it's not used anymore -- To view, visit http://gerrit.cloudera.org:8080/24557 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I55bfed394ac2fb57135fadedd489f59e4cc10de4 Gerrit-Change-Number: 24557 Gerrit-PatchSet: 10 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 16 Sep 2026 12:32:24 +0000 Gerrit-HasComments: Yes
