Hello Kurt Deschler, Zoltan Borok-Nagy, Peter Rozsa, Michael Smith, Impala
Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24814
to look at the new patch set (#7).
Change subject: IMPALA-15354: bump Thrift to 0.24.0 - C++ parts
......................................................................
IMPALA-15354: bump Thrift to 0.24.0 - C++ parts
Switching from 0.16.0-p7 to 0.24.0-p3 needed a few changes:
- Thrift changed the way it prints global output,
needing GlobalOutput() replaced with TOutput::instance()
- some struct sizes shrinked due to not generating virtual
destructors and thus omitting vtable pointers
- patches in TSslSocket were removed in native-toolchain,
moving the logic to Impala by passing SslContext to
Thrift
Removed TSslSocket patches:
https://github.com/cloudera/native-toolchain/blob/master/source/thrift/thrift-0.16.0-patches/0001-TLS-forward-compatibility.patch
https://github.com/cloudera/native-toolchain/blob/master/source/thrift/thrift-0.16.0-patches/0002-IMPALA-11195-Disable-SSL-renegotiations.patch
That area was changed in Thrift, so I decided to move the logic
to Impala instead of rebasing the patches.
Testing:
- the risky parts are the SSL changes, these are fairly covered
in BE and custom cluster tests
Change-Id: Ieea10df03996fef64ea25f51c9e5e4e47c8cefa1
---
M be/src/rpc/TAcceptQueueServer.cpp
M be/src/rpc/thrift-util.cc
M be/src/rpc/thrift-util.h
M be/src/transport/TSaslTransport.h
M be/src/util/container-util.h
M be/src/util/gflag-validator-util-test.cc
M bin/impala-config.sh
7 files changed, 82 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/24814/7
--
To view, visit http://gerrit.cloudera.org:8080/24814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieea10df03996fef64ea25f51c9e5e4e47c8cefa1
Gerrit-Change-Number: 24814
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
