Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24873
to look at the new patch set (#2).
Change subject: IMPALA-15368: Fix heap-buffer-overflow in ParquetDeltaEncoder
for empty pages
......................................................................
IMPALA-15368: Fix heap-buffer-overflow in ParquetDeltaEncoder for empty pages
WorstCaseOutputSize(0) returned 0, but FinalizePage() always writes a
header even when no values were Put() (e.g. an empty page). Callers
that size their output buffer off WorstCaseOutputSize() then have
WriteHeader() write past the end of a too-small (or zero-sized)
buffer. Caught by ASan in
ParquetDeltaLengthByteArrayDecoderTest.EmptyPage.
Fix WorstCaseOutputSize() to return the worst-case header size for
value_count == 0 instead of 0.
Testing:
- parquet-delta-length-byte-array-decoder-test and
parquet-delta-coder-test passed on both a plain debug build and
an ADDRESS_SANITIZER build
Change-Id: I7ab51ae6df3ad97d08da004147c6c9e9a5d82f78
Assisted-by: Claude Sonnet 5 (Claude Code)
---
M be/src/exec/parquet/parquet-delta-encoder.cc
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/24873/2
--
To view, visit http://gerrit.cloudera.org:8080/24873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7ab51ae6df3ad97d08da004147c6c9e9a5d82f78
Gerrit-Change-Number: 24873
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Vanko <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
