Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24890 )
Change subject: IMPALA-15379: Fix UBSan VLA-bound-0 aborts ...................................................................... Patch Set 1: > Patch Set 1: > > There's similar pattern here as well. Should we update this too? > > https://github.com/apache/impala/blob/master/be/src/util/tuple-row-compare.cc#L238 ordering_exprs is probably never empty, but I don't think it would hurt. VLAs are often allocated on the stack, but that code isn't called in a hot loop. -- To view, visit http://gerrit.cloudera.org:8080/24890 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d476f5adc47d2a9e368a8960fa4e7c3817f43fd Gerrit-Change-Number: 24890 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jiyoung Yoo <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 21 Sep 2026 15:39:47 +0000 Gerrit-HasComments: No
