Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24894 )
Change subject: IMPALA-15361: Read Hive 4 timestamp stats ...................................................................... Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/24894/4/fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java File fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java: http://gerrit.cloudera.org:8080/#/c/24894/4/fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java@114 PS4, Line 114: Hive 4 has a This is a Thrift generated class, not some Hive internal calls right? It could be mentioned that it comes from Thrift. Note about possible long term solution: I was thinking about unifying the thrift generated metastore classes in the different Hive shims - my plan is to have a copy of hive_metastore.thrift in Impala based on fresh Hive, and use classes generated from that instead of the ones inherited from Hive metastore client. hive_metastore.thrift should be backward compatible in general, so this could allow using standard thrift functions instead of the reflection below. My goal with this is to reduce Apache Impala's dependency on (CDP) Hive. http://gerrit.cloudera.org:8080/#/c/24894/4/fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java@136 PS4, Line 136: Hive 4 Can you add to the class comments that this is also used with Hive 4, as there is no Hive 4 shim? If there is a relevant ticket, it would be also nice to mention it. -- To view, visit http://gerrit.cloudera.org:8080/24894 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b99acbe65665226938b2e4ac5191063d3925426 Gerrit-Change-Number: 24894 Gerrit-PatchSet: 4 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 23 Sep 2026 09:46:26 +0000 Gerrit-HasComments: Yes
