Csaba Ringhofer has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/24820 )
Change subject: IMPALA-15367: Bump thrift to 0.24.0 - java parts
......................................................................
IMPALA-15367: Bump thrift to 0.24.0 - java parts
Metastore thrift classes are still pulled in from Hive
and are generated with Thrift 0.16.0, which seems genarally
compatible with 0.24.0 runtime.
Thrift 0.24.0 moved from HttpClient 4 to 5, which required
workarounds in some tests:
- JdbcTest: xfail hs2-http tests until Hive also uses Thrift 0.24
- TestCaseLoaderTest: xfail until Hive also uses Thrift 0.24
- LdapHS2Test: don't compile when using Apache Hive, where Impala
uses Thrift 0.11.0
The xfails can be removed once Impala gets a cdp dependency with
Hive that uses Thrift 0.24.0 (IMPALA-15384).
org.apache.httpcomponents has both versions 4 and 5 in Impala,
which is normal as they use different group and arfifact id. There
are many dependencies that use 4 besides old Thrift.
Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Assisted-By: Claude Opus 4.8
Reviewed-on: http://gerrit.cloudera.org:8080/24820
Reviewed-by: Michael Smith <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Quanlong Huang <[email protected]>
---
M bin/impala-config.sh
M fe/pom.xml
M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java
M fe/src/test/java/org/apache/impala/planner/TestCaseLoaderTest.java
M fe/src/test/java/org/apache/impala/service/JdbcTestBase.java
M java/pom.xml
6 files changed, 79 insertions(+), 13 deletions(-)
Approvals:
Michael Smith: Looks good to me, but someone else must approve
Impala Public Jenkins: Verified
Quanlong Huang: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/24820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e15704c9db4b802e5c0ca7fd3e652aa37ee1f2f
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 9
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
