Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24902 )
Change subject: IMPALA-15385: Make AVG_COLLECTION_SIZE a query option ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/24902/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/24902/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@412 PS1, Line 412: options.setAvg_collection_size(0); Can we also add a test for non-zero value (e.g. 100), so a future refactor that breaks the multiplication, changes the formula or drops using this option can't silently pass? -- To view, visit http://gerrit.cloudera.org:8080/24902 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I518f76b38ba926e6ece196f6e90c60f1fa15b5ff Gerrit-Change-Number: 24902 Gerrit-PatchSet: 1 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Thu, 24 Sep 2026 01:58:19 +0000 Gerrit-HasComments: Yes
